Skip to content

CI: Run lint checks once - #3935

Merged
geruh merged 2 commits into
mainfrom
kevinjqliu-deduplicate-python-ci-lint
Sep 11, 2026
Merged

CI: Run lint checks once#3935
geruh merged 2 commits into
mainfrom
kevinjqliu-deduplicate-python-ci-lint

Conversation

@kevinjqliu

Copy link
Copy Markdown
Contributor

Run the lockfile check and linters only on Python 3.12 instead of repeating them across the full matrix.

The matrix still installs, tests, and reports coverage for every supported Python version.

Avoid repeating version-independent lockfile and lint checks across the Python matrix.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@kevinjqliu
kevinjqliu requested review from Fokko and geruh and a lite review from Copilot September 11, 2026 18:00

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No unresolved issues were identified, and coverage remains intact across supported Python versions.

Pull request overview

This PR reduces redundant CI work by running lockfile validation and linting only on Python 3.12 while preserving tests and coverage across the matrix.

Changes:

  • Restricts uv lock --check and make lint to Python 3.12.
  • Retains installation, testing, and coverage for all supported versions.
File summaries
File Summary
.github/workflows/python-ci.yml Adjusts matrix conditions for lockfile checks and linting.
Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@geruh geruh left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't we target the lowest supported version of python? I vaguely remember a lot of changes when deprecating 3.9. Especially since there have also been instances where lint passed for my 3.12 but failed for other versions.

Keep linting deduplicated while checking syntax and typing against the oldest supported interpreter.\n\nCo-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@kevinjqliu

Copy link
Copy Markdown
Contributor Author

shouldn't we target the lowest supported version of python? I vaguely remember a lot of changes when deprecating 3.9. Especially since there have also been instances where lint passed for my 3.12 but failed for other versions.

yea thats a good idea, changed to 3.10

@kevinjqliu
kevinjqliu requested a review from geruh September 11, 2026 19:30
@geruh
geruh added this pull request to the merge queue Sep 11, 2026
Merged via the queue into main with commit 5ba0b43 Sep 11, 2026
21 checks passed
@geruh
geruh deleted the kevinjqliu-deduplicate-python-ci-lint branch September 11, 2026 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants